[3.x] Make binary resource loader utilize loaded external resources #81026
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Razoric480
force-pushed
the
raz/use_resource_cache
branch
from
1072a58
to
3347f7c
Compare
Summersay415
approved these changes
Aug 27, 2023
|
Thanks! |
akien-mga
reviewed
Aug 27, 2023
Razoric480
force-pushed
the
raz/use_resource_cache
branch
from
3347f7c
to
17d8c09
Compare
Doesn't that mean the code you added should be executed only if |
No. This variable is meant to hold external resources in a local cache between |
KoBeWi
approved these changes
Aug 28, 2023
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Binary Resource Loader would load external resources, like TSCN files, twice, and basically discard the first one. It always had a
resource_cacheproperty that got populated, but never actually utilized.When the no-cache flag wasn't being passed along, that issue wasn't noticeable besides longer loading times. Once it started being taken into account, it became noticeable (though it went under the radar until now.)
Fixes #80783