-
-
Notifications
You must be signed in to change notification settings - Fork 20.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
C#: Implement tooltips for Signals and Properties in the inspector. #83505
base: master
Are you sure you want to change the base?
Conversation
3c6209c
to
b0a3350
Compare
Would it be possible to reuse this implementation for documentation of GDShader |
9c21641
to
943ddbc
Compare
601893f
to
4f4ee11
Compare
If this gets approved, it looks like worth setting |
Removing the documentation label, as while this PR deals with documentation generation/display, this is more suited for the dotnet team to handle :) |
02a0e02
to
dd8605f
Compare
Remove the need for |
I feel like this implementation would be better if the Consider the following use-case: Below I have some arbitrary code stub that uses the summary comment to decorate the field such that it would appear in the Godot editor. But I actually also need to annotate the code with a comment because of the ///<summary>
/// Change this string to set the state of the game.
///</summary>
// TODO: remember to expand parsing to include special characters
[Export] private string importantString Now consider my suggestion: // TODO: remember to expand parsing to include special characters
[Export(tooltip: "Change this string to set the state of the game.")]
private string importantString To me it's a lot cleaner and it allows me to separate developer concerns from non-developer concerns. |
Also hoping to see this feature land - adding a note here since the last comment on this issue raises a potential objection to this design and proposes an alternative, but that alternative was discussed (and the implemented approach justified) in the related conversation at godotengine/godot-proposals#8269 . From the current state of that discussion, there seems to be broad agreement that a PR like this one could go forward. Like many of the other commenters, I'm not in love with C#'s XML doc syntax, but interoperability with all my other tools that expect XML docs is a really big win. I think we'd gain a lot by starting there, and supporting the standard doesn't prevent us from allowing more Godot-like syntax for folks who want it in the future. |
I updated the code, but I'm not sure why the PR was automatically closed, and I can't open it anymore. |
resolve godotengine/godot-proposals#8269