Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't rescan filesystem when duplicating #97090

Merged
merged 1 commit into from
Oct 25, 2024

Conversation

KoBeWi
Copy link
Member

@KoBeWi KoBeWi commented Sep 16, 2024

Follow-up to #93372

Makes FileSystem Dock not rescan when duplicating a file or directory. I also tweaked the behavior from #97075 - when EditorFileSystem performs an operation, it doesn't emit changed signal immediately, instead queuing it to the next frame. This ensures that batch operations don't cause more updates than necessary.

There are still some problems though, like error prints or crash when deleting duplicated script. Not sure what causes them yet.

@fire
Copy link
Member

fire commented Sep 17, 2024

Any idea why it's failing on godot-cpp?

@KoBeWi KoBeWi marked this pull request as ready for review September 19, 2024 15:47
@KoBeWi KoBeWi requested a review from a team as a code owner September 19, 2024 15:47
@Hilderin
Copy link
Contributor

Nice job! It's working very well!

@Hilderin
Copy link
Contributor

Tested with a project with a couple thousand of files... The editor seems frozen and doing nothing before reimporting the assets. Maybe add a progress dialog while actually coping the files.

Demonstration:

godot.windows.editor.dev.x86_64_gxgltZHutX.mp4

@KoBeWi
Copy link
Member Author

KoBeWi commented Sep 20, 2024

Added progress bar for copying files (not pushed yet):

godot.windows.editor.dev.x86_64_srwWdCWmbE.mp4

Although feels to me that it makes the operation slower.

@Hilderin
Copy link
Contributor

Although feels to me that it makes the operation slower.

Be sure to pass false to p_force_refresh parameter of the step method. I saw a big help on performance using that trick.

@KoBeWi
Copy link
Member Author

KoBeWi commented Sep 21, 2024

Ok all should be fixed now.

@KoBeWi KoBeWi force-pushed the secret_cloning_research branch 2 times, most recently from 50d051b to 5245d22 Compare September 21, 2024 18:26
@Hilderin
Copy link
Contributor

Hilderin commented Oct 1, 2024

Very nice the new progress bar. Everything seems to work perfectly.

@KoBeWi KoBeWi requested a review from a team as a code owner October 4, 2024 14:15
@Repiteo Repiteo merged commit 6ad513b into godotengine:master Oct 25, 2024
19 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Oct 25, 2024

Thanks!

@KoBeWi KoBeWi deleted the secret_cloning_research branch October 25, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants