-
-
Notifications
You must be signed in to change notification settings - Fork 21.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't rescan filesystem when duplicating #97090
Conversation
Any idea why it's failing on godot-cpp? |
e184ce4
to
1154a2c
Compare
Nice job! It's working very well! |
Tested with a project with a couple thousand of files... The editor seems frozen and doing nothing before reimporting the assets. Maybe add a progress dialog while actually coping the files. Demonstration: godot.windows.editor.dev.x86_64_gxgltZHutX.mp4 |
Added progress bar for copying files (not pushed yet): godot.windows.editor.dev.x86_64_srwWdCWmbE.mp4Although feels to me that it makes the operation slower. |
Be sure to pass false to |
1154a2c
to
6af7029
Compare
Ok all should be fixed now. |
50d051b
to
5245d22
Compare
Very nice the new progress bar. Everything seems to work perfectly. |
5245d22
to
7377ca8
Compare
Thanks! |
Follow-up to #93372
Makes FileSystem Dock not rescan when duplicating a file or directory. I also tweaked the behavior from #97075 - when EditorFileSystem performs an operation, it doesn't emit changed signal immediately, instead queuing it to the next frame. This ensures that batch operations don't cause more updates than necessary.
There are still some problems though, like error prints or crash when deleting duplicated script. Not sure what causes them yet.