[DRAFT] Add external texture support (Vulkan) #97163
Draft
+791
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…atibility renderer
Co-authored-by: Fredia Huya-Kouadio <[email protected]> Co-authored-by: Mauricio Narvaez <[email protected]>
dsnopek
force-pushed
the
external-texture-vulkan
branch
from
152a872
to
662f7f9
Compare
|
According to https://composables.com/android-distribution-chart, we go from 99.7% to 95.4% coverage if we raise the min API from 21 to 26. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This builds on top of PR #96982 to add external texture support for Vulkan.
This is an unfinished work-in-progress.
I ended up splitting this off into its own PR to finish later after I discovered that this will only work with Android API level 26 or higher. Presently, we have an API minimum of 21, which prevents this code from compiling.
So, I'll save this until after we increase the API minimum to 21 or higher. (Another option is including the code, but then requiring users to build with
scons ndk_platform=android-26in order to support this feature, but it wouldn't be included in official builds.)