Fix Undo/Redo not working in Bezier Animation Editor when moving keys #97169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akien-mga
approved these changes
Sep 19, 2024
akien-mga
added
the
cherrypick:4.3
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #97146, introduced by #96753
In the PR I was registering the animation refresh do and undo method call inside AnimationBezierTrackEdit::_bezier_track_insert_key_at_anim thinking it was the correct place to refresh once the track is moved.
This is incorrect since this method itself is called by the undo_redo.commit() registed back in gui_input. So I moved it to the ape call to gui_input, after all other undo_redo callbacks caused by a move are registered.