Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set auto translate mode for drag previews #97173

Merged
merged 1 commit into from
Sep 19, 2024

Conversation

timothyqiu
Copy link
Member

  • Controls
    • LineEdit, TextEdit: Always disabled since it's dragging user input.
    • TabBar: Use the same auto translate mode as the node.
    • RichTextLabel: Always disable since auto translation is done differently from other controls (selection text you get programmatically is always after auto translation).
  • Editor
    • Disable drag preview auto translation if the text is user input, filename, or class name.
    • Also disabled unexpected auto translation for audio bus effect names.

- Controls
  - `LineEdit`, `TextEdit`: Always disabled since it's dragging user input.
  - `TabBar`: Use the same auto translate mode as the node.
  - `RichTextLabel`: Always disable since auto translation is done
    differently from other controls (selection text you get
    programmatically is always after auto translation).
- Editor
  - Disable drag preview auto translation if the text is user input,
    filename, or class name.
  - Also disabled unexpected auto translation for audio bus effect names.
@akien-mga akien-mga merged commit d788205 into godotengine:master Sep 19, 2024
20 checks passed
@akien-mga
Copy link
Member

Thanks!

@timothyqiu timothyqiu deleted the drag-preview-translation branch September 20, 2024 00:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants