Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTTPRequest make working with headers easier #97174

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

pafuent
Copy link
Contributor

@pafuent pafuent commented Sep 19, 2024

Adding HTTPRequest::get_dictionary_from_headers to get a Dictionary from headers parameter on request_completed.
Making HTTPRequest::has_header and HTTPRequest::get_header_value public.

@pafuent pafuent requested review from a team as code owners September 19, 2024 02:29
@pafuent
Copy link
Contributor Author

pafuent commented Sep 19, 2024

FYI @Kubulambula

@pafuent pafuent force-pushed the http_request_header_utility_functions branch from 91416ff to a127011 Compare September 19, 2024 02:39
@AThousandShips AThousandShips changed the title HTTPRequest making working with headers easier HTTPRequest make working with headers easier Sep 19, 2024
@AThousandShips AThousandShips added this to the 4.x milestone Sep 19, 2024
@AThousandShips
Copy link
Member

You linked the wrong issue in your commit message, please just remove it when you push next

@pafuent
Copy link
Contributor Author

pafuent commented Oct 3, 2024

Friendly remainder

Closes godotengine/godot-proposals#4734

Adding `HTTPRequest::get_dictionary_from_headers` to get a Dictionary
from `headers` parameter on `request_completed`.
Making `HTTPRequest::has_header` and `HTTPRequest::get_header_value` public.

Co-Authored-By: =?UTF-8?q?Jakub=20Jan=C5=A1ta?= <[email protected]>
@pafuent pafuent force-pushed the http_request_header_utility_functions branch from 70338e1 to 48776ce Compare October 17, 2024 13:27
@pafuent
Copy link
Contributor Author

pafuent commented Oct 17, 2024

Friendly remainder

@AThousandShips AThousandShips requested a review from a team October 18, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Make working with headers trough HTTPRequest easier
2 participants