Add error messages to BindingsGenerator
#97194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RadiantUwU
approved these changes
Sep 20, 2024
AThousandShips
approved these changes
Sep 20, 2024
raulsntos
approved these changes
Sep 20, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While experimenting with C# code generation to fix CI issues in #82198 , it became really useful to see exactly which types were coming up not found by adding an error message to the null checks. I pulled in those messages for this standalone PR to hopefully improve the debugging experience when a missing type causes an issue :)
Whenever
_get_type_or_nullis used, it already depends on the providedTypeReferencenot being null, so it is safe to print thecnamein these messages. Let me know if it looks good, thanks!