Fix TabContainer tab offset moving when not needed #97209
+6
−3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It was caused by the call to
set_anchors_and_offsets_preset(PRESET_TOP_WIDE);since it reset the left and right offsets and then the TabBar resizes and changes the tab offset to fit. The offsets were fixed after, but the tab offset was already changed. The call to_update_marginsis no longer needed.I made sure that the anchors and offsets are the same as before:
tabs_position: top
anchors: top 0, bot 0, left 0, right 1
offsets: top 0, bot 31, left 8, right 0
tabs_position: bottom
anchors: top 1, bot 1, left 0, right 1
offsets: top -31, bot 0, left 8, right 0