Improve synchronization of rendering after changes from transfer queues. #98388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sfer queues. Fix an error where barriers are expected to be inserted for the swap chain textures. Add the relevant synchronization stages and accesses to resources between frames. Fix an error where debug labels weren't finished correctly between frames. Breadcrumbs are now behind an optional macro as they currently lead to synchronization errors which are harmless.
|
Thanks! |
darksylinc
added a commit
to darksylinc/godot
that referenced
this pull request
Oct 23, 2024
Adds "--accurate-breadcrumbs" CLI command Additionally, leave out breadcrumbs code in non-debug, non-dev builds. Fix regression introduced in godotengine#98388 where command_insert_breadcrumb() is called even in non-debug builds. Fixes godotengine#98338
laurentmackay
pushed a commit
to metapfhor/godot
that referenced
this pull request
Oct 30, 2024
Adds "--accurate-breadcrumbs" CLI command Additionally, leave out breadcrumbs code in non-debug, non-dev builds. Fix regression introduced in godotengine#98388 where command_insert_breadcrumb() is called even in non-debug builds. Fixes godotengine#98338
MarcusPaulsson
pushed a commit
to MarcusPaulsson/godot
that referenced
this pull request
Nov 5, 2024
Adds "--accurate-breadcrumbs" CLI command Additionally, leave out breadcrumbs code in non-debug, non-dev builds. Fix regression introduced in godotengine#98388 where command_insert_breadcrumb() is called even in non-debug builds. Fixes godotengine#98338
JayTropper
pushed a commit
to JayTropper/godot
that referenced
this pull request
Nov 6, 2024
Adds "--accurate-breadcrumbs" CLI command Additionally, leave out breadcrumbs code in non-debug, non-dev builds. Fix regression introduced in godotengine#98388 where command_insert_breadcrumb() is called even in non-debug builds. Fixes godotengine#98338
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After transfer queues were merged, some new unexpected synchronization errors popped up that were previously not encountered because the setup queue was introducing its own barriers and forcing most of the caches to be flushed through a global memory barrier.
These changes introduce proper synchronization tracking for usages on the previous frame, as the hazards were not visible inside the same frame but rather between frames. This has fixed some flickering that was visible in the TPS Demo in Mobile that did not happen before #90400 was merged.
This PR also fixes an error where debug labels were not being properly closed each frame, leading to the labels leaking into the next frames and causing them to keep growing in depth.