Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Web] Disable UNIX sockets #98954

Merged
merged 2 commits into from
Nov 13, 2024
Merged

[Web] Disable UNIX sockets #98954

merged 2 commits into from
Nov 13, 2024
+50 −46

Commits on Nov 13, 2024

  1. [Net] Properly rename NetSocketPosix to NetSocketUnix

    @Faless
    Faless committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    fc52821 View commit details
    Browse the repository at this point in the history

  2. [Web] Disable UNIX sockets 

    They are not supported anyway, emscripten has an emulation layer that
implements them over WebSocket/WebRTC, which is really surprising for
users, and also not very useful since we have proper WebSocket and
WebRTC support.

This can make the build smaller, if we also disable the UPNP module
(which will otherwise include a third party library referencing "socket"
thus forcing emscripten to include the compatibility layer)
    @Faless
    Faless committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    9383610 View commit details
    Browse the repository at this point in the history