Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ref and HashSet to godot.natvis #98961

Merged
merged 1 commit into from
Nov 10, 2024

Conversation

mihe
Copy link
Contributor

@mihe mihe commented Nov 8, 2024

HashSet is currently missing from godot.natvis (Microsoft's debugger visualization) which makes inspecting such containers in for example Visual Studio or Visual Studio Code quite tedious at the moment.

This PR fixes that by visualizing HashSet as <ArrayItems>, same as Vector.

I also threw in a visualizer for Ref, since there's none currently, which largely mimicks the visualizer that MSVC provides for std::unique_ptr, except I added an <Expand> item for the reference counter as well.

@Repiteo Repiteo merged commit 1789ad3 into godotengine:master Nov 10, 2024
20 checks passed
@Repiteo
Copy link
Contributor

Repiteo commented Nov 10, 2024

Thanks!

@mihe mihe deleted the natvis-improvements branch November 11, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants