Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deadlocks related to ClassDB queries about global classes #98963

Merged
merged 1 commit into from
Nov 10, 2024

Commits on Nov 8, 2024

  1. Fix deadlocks related to ClassDB queries about global classes

    `ClassDB::can_instantiate()` and other reflection methods deadlock if the type is an script global class, when such script indirectly uses a not-yet-registered class. The reason is the `ClassDB` read lock is still held when invoking the `ResourceLoader` to load the class script, which may in turn need to lock for writing (for the class registration).
    
    In particular, this happens with some types related to animation tree, that aren't registered at engine startup, but can happen with others, especially ones from the user. Registration statements are also added for the animation-related types that were lacking them.
    RandomShaper committed Nov 8, 2024
    Configuration menu
    Copy the full SHA
    56bdef9 View commit details
    Browse the repository at this point in the history