[Net] Split Unix/Windows NetSocket implementation #98969
Merged
+803
−260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamscott
approved these changes
Nov 8, 2024
hpvb
reviewed
Nov 8, 2024
Faless
force-pushed
the
net/split_sockets
branch
from
9963853
to
608ea48
Compare
|
Oh hey, if/when |
Yeah, I can work on that too, I think we would still not want to hard-code the platform names there, so probably the platforms |
AThousandShips
approved these changes
Nov 10, 2024
Faless
force-pushed
the
net/split_sockets
branch
from
608ea48
to
0c620b2
Compare
akien-mga
approved these changes
Nov 11, 2024
mhilbrunner
approved these changes
Nov 12, 2024
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As expected, this results in quite some code duplication, but also make a clearer split between Unix and Windows socket implementation.