Add CATEGORY_UNDEFINED option in Android export
#98971
Merged
+13
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syntaxerror247
changed the title
other
syntaxerror247
changed the title
m4gr3d
requested changes
Nov 8, 2024
syntaxerror247
force-pushed
the
new_appCategory
branch
from
ceb84d7
to
6de0cda
Compare
syntaxerror247
changed the title
syntaxerror247
changed the title
CATEGORY_UNDEFINED option in Android export
syntaxerror247
force-pushed
the
new_appCategory
branch
from
6de0cda
to
b2cb858
Compare
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app category is optional in Android, but currently, there is no option in the Godot editor to leave it undefined. In this PR, I have introduced a new category, UNDEFINED. When this category is selected, the
appCategorywill not be defined in the Android manifest file.I have implemented logic to remove this attribute completely during the Gradle build export. However, in the normal export, I am setting its value to
-1instead.