Move D3D12 fence SetEventOnCompletion call to fence_wait to avoid stalling on some platforms
#98975
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lling on some platforms
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a weird one and hasn't been reported upstream.
Basically
SetEventOnCompletion()should be fine to call anytime after theSignal()and before we wait on the fence. The docs don't indicate that it should stall, but in testing, it appears that there are cases where it will stall until GPU work finishes. In any case, all the official samples callSetEventOnCompletion()immediately beforeWaitForSingleObjectEx()so we should do the same.In testing with our complex 3D test project on the affected hardware we get roughly double the performance from this change.