Prevent stack-use-after-scope in rendering_device_driver_metal.mm #98983
+2
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a stack-use-after-scope error that I was getting on MacOS with sanitizers:
The problem is when it tries to get a reference from get_entry_points_and_stages().front(), but since the SmallVector that get_entry_points_and_stages() passes back is dynamically created, it deconstructs right after front() passes back that reference, thus we keep a reference to something that is no longer in scope.
Keeping that vector in scope fixes the issue.
asan.log