Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement default_canvas_cull_mask #98989

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Summersay415
Copy link
Contributor

@Summersay415 Summersay415 commented Nov 9, 2024

@Summersay415 Summersay415 requested review from a team as code owners November 9, 2024 10:53
@Summersay415 Summersay415 force-pushed the canvas-layers branch 2 times, most recently from 0d3a326 to 1ce9e28 Compare November 9, 2024 11:06
@Summersay415

This comment was marked as resolved.

@ydeltastar
Copy link
Contributor

ydeltastar commented Nov 10, 2024

This should probably go in the SceneTree's initialization instead of main.

@Summersay415
Copy link
Contributor Author

Summersay415 commented Nov 12, 2024

This should probably go in the SceneTree's initialization instead of main.

The problem is that it needs to apply only in game, not in the editor. In main there is a clean check, what should I do in SceneTree then?

@ydeltastar
Copy link
Contributor

ydeltastar commented Nov 12, 2024

The problem is that it needs to apply only in game, not in the editor.

Project settings should be applied in real-time in the editor so you can preview it and match runtime as closely as possible.
You can override it for feature tags like editor_runtime and release if you want a setting to apply only in the running project.

@Summersay415
Copy link
Contributor Author

The problem is that it needs to apply only in game, not in the editor.

Project settings should be applied in real-time in the editor so you can preview it and match runtime as closely as possible.
You can override it for feature tags like editor_runtime and release if you want a setting to apply only in the running project.

Good idea!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a Default Canvas Cull Mask project setting
6 participants