update for fiber v3 #437
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,39 +1,39 @@ | ||
| name: Govulncheck Security Scan | ||
|
|
||
| on: | ||
| push: | ||
| branches: | ||
| - "master" | ||
| - "main" | ||
| paths-ignore: | ||
| - "**.md" | ||
| - LICENSE | ||
| - ".github/ISSUE_TEMPLATE/*.yml" | ||
| - ".github/dependabot.yml" | ||
| pull_request: | ||
| branches: | ||
| - "*" | ||
| paths-ignore: | ||
| - "**.md" | ||
| - LICENSE | ||
| - ".github/ISSUE_TEMPLATE/*.yml" | ||
| - ".github/dependabot.yml" | ||
|
|
||
| jobs: | ||
| govulncheck-check: | ||
| runs-on: ubuntu-latest | ||
| env: | ||
| GO111MODULE: on | ||
| steps: | ||
| - name: Fetch Repository | ||
| uses: actions/checkout@v5 | ||
| - name: Install Go | ||
| uses: actions/setup-go@v5 | ||
| with: | ||
| go-version: '1.25.x' | ||
| check-latest: false | ||
| cache: false | ||
| - name: Install Govulncheck | ||
| run: go install golang.org/x/vuln/cmd/govulncheck@latest | ||
| - name: Run Govulncheck | ||
| run: govulncheck ./... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -43,8 +43,8 @@ package main | |
| import ( | ||
| "log" | ||
|
|
||
| "github.com/gofiber/fiber/v3" | ||
| "github.com/gofiber/template/ace/v3" | ||
|
Comment on lines
+54
to
+55
There was a problem hiding this comment. 🧩 Analysis chainVerify version consistency across documentation and implementation. The README example references
Additionally, replace hard tabs with spaces on these lines to comply with markdown formatting standards. Apply this diff to fix the indentation: import (
- "log"
-
- "github.com/gofiber/fiber/v3"
- "github.com/gofiber/template/ace/v3"
+ "log"
+
+ "github.com/gofiber/fiber/v3"
+ "github.com/gofiber/template/ace/v3"
)I need to examine the codebase to verify the concerns raised in the review comment. Let me investigate the actual imports and file structure. 🏁 Script executed: #!/bin/bash
# Find and examine template engine implementation files
echo "=== Searching for template engine files ==="
fd -e go -path "*template*" | head -20
echo ""
echo "=== Examining ace directory structure ==="
fd -type f "ace" | head -20
echo ""
echo "=== Looking for implementation files (pug.go, html.go, slim.go, ace.go) ==="
fd "(pug|html|slim|ace)\.go$"
echo ""
echo "=== Checking ace/README.md content ==="
fd "README.md" -path "*ace*" -exec cat {} \;
echo ""
echo "=== Examining actual imports in template files ==="
if [ -f "pug.go" ]; then echo "=== pug.go ==="; grep -A5 "^import" pug.go; fi
if [ -f "html.go" ]; then echo "=== html.go ==="; grep -A5 "^import" html.go; fi
if [ -f "slim.go" ]; then echo "=== slim.go ==="; grep -A5 "^import" slim.go; fi
if [ -f "ace.go" ]; then echo "=== ace.go ==="; grep -A5 "^import" ace.go; fiLength of output: 812 🏁 Script executed: #!/bin/bash
echo "=== ace/ace.go imports ==="
cat ace/ace.go | grep -A10 "^import"
echo ""
echo "=== html/html.go imports ==="
cat html/html.go | grep -A10 "^import"
echo ""
echo "=== pug/pug.go imports ==="
cat pug/pug.go | grep -A10 "^import"
echo ""
echo "=== slim/slim.go imports ==="
cat slim/slim.go | grep -A10 "^import"
echo ""
echo "=== ace/README.md lines 40-55 ==="
cat ace/README.md | sed -n '40,55p'
echo ""
echo "=== Checking for tabs in ace/README.md lines 46-47 ==="
cat ace/README.md | sed -n '46,47p' | od -c | head -20Length of output: 1018 🏁 Script executed: #!/bin/bash
echo "=== Detailed view of ace/README.md lines 44-50 ==="
sed -n '44,50p' ace/README.md | cat -A
echo ""
echo "=== Full pug/pug.go imports section ==="
cat pug/pug.go | head -30Length of output: 662 🌐 Web query: 💡 Result: Short answer: There is no official github.com/gofiber/template/ace/v3 package — the Ace wrapper is published as v2. So there isn’t an official "ace v3" release to match Fiber v3; use github.com/gofiber/template/ace/v2 (or embed a compatible Ace engine) and the Fiber Views interface instead. Sources: Fiber template docs (Ace examples using ace/v2) and the gofiber/template listing. [1][2] References
Update README.md to fix version inconsistency and formatting. The version mismatch is confirmed: all template implementations (ace, html, slim) import import (
- "log"
-
- "github.com/gofiber/fiber/v3"
- "github.com/gofiber/template/ace/v3"
+ "log"
+
+ "github.com/gofiber/fiber/v3"
+ "github.com/gofiber/template/ace/v2"
)🧰 Tools🪛 markdownlint-cli2 (0.18.1)46-46: Hard tabs (MD010, no-hard-tabs) 47-47: Hard tabs (MD010, no-hard-tabs) 🤖 Prompt for AI Agents |
||
| ) | ||
|
|
||
| func main() { | ||
|
|
@@ -60,14 +60,14 @@ func main() { | |
| Views: engine, | ||
| }) | ||
|
|
||
| app.Get("/", func(c fiber.Ctx) error { | ||
| // Render index | ||
| return c.Render("index", fiber.Map{ | ||
| "Title": "Hello, World!", | ||
| }) | ||
| }) | ||
|
|
||
| app.Get("/layout", func(c fiber.Ctx) error { | ||
| // Render index within layouts/main | ||
| return c.Render("index", fiber.Map{ | ||
| "Title": "Hello, World!", | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -10,7 +10,7 @@ import ( | |
| "path/filepath" | ||
| "strings" | ||
|
|
||
| core "github.com/gofiber/template/v2" | ||
| "github.com/gofiber/utils" | ||
| "github.com/yosssi/ace" | ||
| ) | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
| @@ -1,11 +1,11 @@ | ||||||
| module github.com/gofiber/template/ace/v3 | ||||||
|
|
||||||
| go 1.25 | ||||||
|
There was a problem hiding this comment. The
Suggested change
|
||||||
|
|
||||||
| require github.com/yosssi/ace v0.0.5 | ||||||
|
|
||||||
| require ( | ||||||
| github.com/gofiber/template/v2 v2.0.0 | ||||||
| github.com/gofiber/utils v1.1.0 | ||||||
| github.com/stretchr/testify v1.11.1 | ||||||
| ) | ||||||
|
|
@@ -16,4 +16,4 @@ require ( | |||||
| gopkg.in/yaml.v3 v3.0.1 // indirect | ||||||
| ) | ||||||
|
|
||||||
| replace github.com/gofiber/template/v2 => ../. | ||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The required Go version is set to
1.25, which has not been released yet. This will cause confusion and prevent users from using this library with current stable Go versions. The new code usesreflect.MapRange, which was introduced in Go 1.22. I suggest setting the minimum required version to1.22.