Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JDS Components #140

Open
wants to merge 6 commits into
base: jds-2.0
Choose a base branch
from
Open

JDS Components #140

wants to merge 6 commits into from

Conversation

vijayanandsp
Copy link

No description provided.

padding: 10px 20px;
border: 1px solid #ddd;
color: @BlackColor;
background-color: @PrimaryTextColor!important;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

avoid using !important

.nitrozen-select:focus-within {
border-color: @SecondaryColor;
}
.nitrozen-select__trigger {
color: @TypographyPrimaryColor;
border-radius: 3px;
font-size: 14px;
// border-radius: 3px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove the comments

@@ -217,7 +259,7 @@
}

.n-button-rounded {
border-radius: 40px;
border-radius: 1000px;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1000px instead use %
use relative units, please instead of absolute

@@ -232,7 +274,7 @@
}

.n-button-mid {
height: 4.8rem;
// height: 4.8rem;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove comments

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants