Skip to content

Commit

Permalink
Change setHealth to setUnHealth to avoid misunderstanding (#21047)
Browse files Browse the repository at this point in the history
fixes #19923

Signed-off-by: stonezdj <[email protected]>
  • Loading branch information
stonezdj authored Oct 17, 2024
1 parent 5ac9733 commit c14c3db
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 2 deletions.
4 changes: 3 additions & 1 deletion src/portal/src/app/app.component.ts
Original file line number Diff line number Diff line change
Expand Up @@ -88,7 +88,9 @@ export class AppComponent implements OnInit, OnDestroy {
if (this.sessionService.getCurrentUser()?.has_admin_role) {
this.jobServiceDashboardHealthCheckService.checkHealth();
} else {
this.jobServiceDashboardHealthCheckService.setHealthy(true);
this.jobServiceDashboardHealthCheckService.setUnHealthy(
false
);
}
}, CHECK_HEALTH_INTERVAL);
}
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export class JobServiceDashboardHealthCheckService {
return this._hasManuallyClosed;
}

setHealthy(value: boolean): void {
setUnHealthy(value: boolean): void {
this._hasUnhealthyQueue = value;
}
setManuallyClosed(value: boolean): void {
Expand Down

0 comments on commit c14c3db

Please sign in to comment.