Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compare user and pass hashes simultaneously to avoid leaking if the username is valid #23

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Compare user and pass hashes simultaneously to avoid leaking if the username is valid #23

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8b9be01
Add go.mod file
nvx Sep 28, 2021
81d1e02
Compare user and pass hashes simultaneously to avoid leaking if the
nvx Sep 28, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions basic_auth.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,9 +102,14 @@ func (b *basicAuth) simpleBasicAuthFunc(user, pass string, r *http.Request) bool
requiredUser := sha256.Sum256([]byte(b.opts.User))
requiredPass := sha256.Sum256([]byte(b.opts.Password))

// Combine user and pass hashes together into single byte
// array to ensure constant time comparison no matter the
// combination of user or pass matching.
givenUserPass := append(givenUser[:], givenPass[:]...)
requiredUserPass := append(requiredUser[:], requiredPass[:]...)

// Compare the supplied credentials to those set in our options
if subtle.ConstantTimeCompare(givenUser[:], requiredUser[:]) == 1 &&
subtle.ConstantTimeCompare(givenPass[:], requiredPass[:]) == 1 {
if subtle.ConstantTimeCompare(givenUserPass[:], requiredUserPass[:]) == 1 {
return true
}

Expand Down
3 changes: 3 additions & 0 deletions go.mod
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
module github.com/goji/httpauth

go 1.17