Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Merge outstanding upstream PR #8

Closed
wants to merge 4 commits into from
Closed

Merge outstanding upstream PR #8

wants to merge 4 commits into from

Commits on Oct 17, 2018

  1. Add go.mod

    @thatguystone
    thatguystone committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    b20fde1 View commit details
    Browse the repository at this point in the history

  2. Use conventional error handling

    @thatguystone
    thatguystone committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    2a809f2 View commit details
    Browse the repository at this point in the history

  3. parse{num}: Return the error from strconv.NumError 

    Returning the full error just adds extra noise to the error since it's
already clear that there was an error with the number. This now says
exactly what is wrong with the number.
    @thatguystone
    thatguystone committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    9a639f3 View commit details
    Browse the repository at this point in the history

  4. Rename TypeError to ValueError 

    A TypeError typically refers to the go type of something. This error is
used to indicate that the value cannot be parsed correctly.
    @thatguystone
    thatguystone committed Oct 17, 2018
    Configuration menu
    Copy the full SHA
    bfb29fd View commit details
    Browse the repository at this point in the history