Skip to content

Conversation

@Hello-world150
Copy link

Capitalize the first letter to match most desktop file conventions.

Capitalize the first letter to match most desktop file conventions.
Copy link
Collaborator

@CatsDeservePets CatsDeservePets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted to see what other applications do:

So I guess it does make sense to use Lf as a name. However, before merging this I want @joelim-work to look over this as I don't know whether this could potentially cause problems with packages or something like that and whether this should be added to the changelog.

@Hello-world150
Copy link
Author

I wanted to see what other applications do:

So I guess it does make sense to use Lf as a name. However, before merging this I want @joelim-work to look over this as I don't know whether this could potentially cause problems with packages or something like that and whether this should be added to the changelog.

If downstream maintainers are just packaging the files into the software package, this shouldn't have much impact. As for the change log, I tend not to record it, because this change doesn't make any substantial modifications.

Copy link
Collaborator

@joelim-work joelim-work left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the Desktop Entry Specification, the Name field doesn't mention any requirements about capitalization:

Specific name of the application, for example "Mozilla".

My understanding is that Name is purely cosmetic, and should reflect the official branding name. The original author of this project (@gokcehan) isn't actively involved these days, but based on what I have seen the name is actually lowercase (usually the docs refer to it as lf, not lf or Lf or LF).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants