Fix: ensureVersionTable & ensureLockTable perfomance. #1058
+2
−24
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
removing select query on information_schema tables. Such query are expensive ones.
dhui
reviewed
Apr 16, 2024
Member
dhui
left a comment
dhui
left a comment
There was a problem hiding this comment.
@Deepak-dash007 this change is promising!
Could you rebase and see if tests pass?
Author
|
@dhui I have rebased the Pull Request, Can you review again? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue : #1052
ensureLockTable&ensureLockTableruns select query oninformation_schemato check weather tables exist.such query are expensive. It takes around ~
15Secwhen the information_schema is loaded with multiple schemas and tables.We can avoid that and make the table creation query
Idempotent. Which reduces thelatency to < 1Sec