-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
net/http: only disable fetch in test #69289
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: fb4bdb6) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/611215. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/611215. |
Message from Zxilly Chou: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/611215. |
Message from Johan Brandhorst-Satzkorn: Patch Set 2: Code-Review+2 Commit-Queue+1 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/611215. |
Message from Go LUCI: Patch Set 2: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-09-05T16:53:03Z","revision":"e4befa74861b0bd2638637bb664741eb56d88b80"} Please don’t reply on this GitHub thread. Visit golang.org/cl/611215. |
Message from Johan Brandhorst-Satzkorn: Patch Set 2: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/611215. |
Message from Go LUCI: Patch Set 2: This CL has failed the run. Reason: Tryjob golang/try/gotip-linux-arm64 has failed with summary (view all results):
Build or test failure, click here for results. To reproduce, try Additional links for debugging: Please don’t reply on this GitHub thread. Visit golang.org/cl/611215. |
Message from Go LUCI: Patch Set 2: LUCI-TryBot-Result-1 Please don’t reply on this GitHub thread. Visit golang.org/cl/611215. |
Message from Zxilly Chou: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/611215. |
Message from Zxilly Chou: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/611215. |
Message from Johan Brandhorst-Satzkorn: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/611215. |
Message from Johan Brandhorst-Satzkorn: Patch Set 2: -Code-Review Please don’t reply on this GitHub thread. Visit golang.org/cl/611215. |
Message from Zxilly Chou: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/611215. |
Message from Johan Brandhorst-Satzkorn: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/611215. |
This PR (HEAD: 140640b) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/611215. Important tips:
|
Message from Zxilly Chou: Patch Set 2: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/611215. |
Message from Zxilly Chou: Patch Set 3: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/611215. |
Message from Ian Lance Taylor: Patch Set 3: Commit-Queue+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/611215. |
Message from Go LUCI: Patch Set 3: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2024-09-07T20:46:32Z","revision":"39256ffd2f08f7acf7dcf00900ac83b26e8b8955"} Please don’t reply on this GitHub thread. Visit golang.org/cl/611215. |
Message from Ian Lance Taylor: Patch Set 3: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/611215. |
Message from Go LUCI: Patch Set 3: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/611215. |
Message from Go LUCI: Patch Set 3: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/611215. |
Message from Dmitri Shuralyov: Patch Set 3: (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/611215. |
This change allows the js/wasm port binary to perform network
access correctly on Node.js without breaking tests
that have not yet been migrated.
Updates #57613
Fixes #69106