cmd: use omitzero option for time.Time #69905

callthingsoff · 2024-10-16T14:31:59Z

The doc of time.Time says:
Programs using times should typically store and pass them as values,
not pointers. That is, time variables and struct fields should be of type
time.Time, not *time.Time.

Since CL 615676 added omitzero option to encoding/json package, we can
just replace (*time.Time + omitempty) with (time.Time + omitzero).

The doc of time.Time says: Programs using times should typically store and pass them as values, not pointers. That is, time variables and struct fields should be of type time.Time, not *time.Time. Since CL 615676 added omitzero option to encoding/json package, we can just replace (*time.Time + omitempty) with (time.Time + omitzero). Change-Id: I5593c4b45af291d015433bd1d164f1c1378db642

gopherbot · 2024-10-16T14:39:38Z

This PR (HEAD: 9f0d66f) has been imported to Gerrit for code review.

Please visit Gerrit at https://go-review.googlesource.com/c/go/+/620595.

Important tips:

Don't comment on this PR. All discussion takes place in Gerrit.
You need a Gmail or other Google account to log in to Gerrit.
To change your code in response to feedback:
- Push a new commit to the branch used by your GitHub PR.
- A new "patch set" will then appear in Gerrit.
- Respond to each comment by marking as Done in Gerrit if implemented as suggested. You can alternatively write a reply.
- Critical: you must click the blue Reply button near the top to publish your Gerrit responses.
- Multiple commits in the PR will be squashed by GerritBot.
The title and description of the GitHub PR are used to construct the final commit message.
- Edit these as needed via the GitHub web interface (not via Gerrit or git).
- You should word wrap the PR description at ~76 characters unless you need longer lines (e.g., for tables or URLs).
See the Sending a change via GitHub and Reviews sections of the Contribution Guide as well as the FAQ for details.

gopherbot · 2024-10-16T14:48:04Z

Message from Gopher Robot:

Patch Set 1:

(1 comment)