-
Notifications
You must be signed in to change notification settings - Fork 17.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
lib/wasm: utf8 is an invalid param for TextEncoder
#72939
base: master
Are you sure you want to change the base?
Conversation
This PR (HEAD: 29f2c89) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/go/+/659075. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/659075. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be During May-July and Nov-Jan the Go project is in a code freeze, during which Please don’t reply on this GitHub thread. Visit golang.org/cl/659075. |
Message from Jorropo: Patch Set 1: Code-Review+2 Commit-Queue+1 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/659075. |
Message from Go LUCI: Patch Set 1: Dry run: CV is trying the patch. Bot data: {"action":"start","triggered_at":"2025-03-20T02:03:29Z","revision":"ed622f103819a7ba8090a4a96a8ccda21d680bd4"} Please don’t reply on this GitHub thread. Visit golang.org/cl/659075. |
Message from Jorropo: Patch Set 1: -Commit-Queue Please don’t reply on this GitHub thread. Visit golang.org/cl/659075. |
Message from Go LUCI: Patch Set 1: This CL has passed the run Please don’t reply on this GitHub thread. Visit golang.org/cl/659075. |
Message from Go LUCI: Patch Set 1: LUCI-TryBot-Result+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/659075. |
Message from Cherry Mui: Patch Set 1: Code-Review+2 (2 comments) Please don’t reply on this GitHub thread. Visit golang.org/cl/659075. |
Message from Zxilly Chou: Patch Set 1: Code-Review+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/659075. |
Message from Zxilly Chou: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/659075. |
TextEncoder
TextEncoder
Message from Jorropo: Patch Set 2: Code-Review+2 (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/659075. |
As per https://developer.mozilla.org/en-US/docs/Web/API/TextEncoder or more specifically https://www.w3.org/TR/2020/NOTE-encoding-20200602/#ref-for-dom-textencoder
PS: This is a two line commit, I have an additional 1-line commit I can add to this if you like: