-
Notifications
You must be signed in to change notification settings - Fork 1k
jwt: move the scope from assertion payload to the request parameter as in RFC7521 #781
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
I've signed the CLA, how the CLA check can be triggered again? |
This PR (HEAD: 5a6f7b3) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/685735. Important tips:
|
Message from Gopher Robot: Patch Set 1: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/685735. |
Message from Gopher Robot: Patch Set 1: Congratulations on opening your first change. Thank you for your contribution! Next steps: Most changes in the Go project go through a few rounds of revision. This can be Please don’t reply on this GitHub thread. Visit golang.org/cl/685735. |
This PR (HEAD: be711be) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/685735. Important tips:
|
This PR (HEAD: e9d852a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/685735. Important tips:
|
This PR (HEAD: 4ef8b3a) has been imported to Gerrit for code review. Please visit Gerrit at https://go-review.googlesource.com/c/oauth2/+/685735. Important tips:
|
Message from Sean Liao: Patch Set 5: (1 comment) Please don’t reply on this GitHub thread. Visit golang.org/cl/685735. |
Message from Sean Liao: Patch Set 5: Hold+1 Please don’t reply on this GitHub thread. Visit golang.org/cl/685735. |
This PR adjust the jwt package to send scopes as request parameter as described in the RFC https://datatracker.ietf.org/doc/html/rfc7521#section-4.1
#461
this pr also adds support for multiple audiences as described in RFC 7519.