chore: resolve isolation warnings related to EnvironmentKey
#388
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most `EnvironmentKey` implementations produce the following warning when strict concurrency warnings are enabled: ``` warning: static property 'defaultValue' is not concurrency-safe because it is non-isolated global shared mutable state; this is an error in the Swift 6 language mode ``` Switching from `var` to `let` resolves the issue.
cweider
commented
Feb 12, 2025
| @@ -13,9 +13,9 @@ extension EnvironmentValues { | |||
| } | |||
|
|
|||
| private struct BaseURLKey: EnvironmentKey { | |||
| static var defaultValue: URL? = nil | |||
| static var defaultValue: URL? { nil } | |||
There was a problem hiding this comment.
Dunno what your taste is for indentation - lemme know.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most
EnvironmentKeyimplementations produce this warning when strict concurrency warnings are enabled:Switching from
vartoletresolves the issue.