chore: enable upcoming feature InferSendableFromCaptures
#390
+9
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A massive number of concurrency warnings concern `KeyPath` and issues with its sendability. Rather than chase these down make use of SE-0418, "Inferring Sendable for Methods and KeyPath Literals". `swift-tools-version` is updated to 5.10, making the upcoming feature, `InferSendableFromCaptures` available. Once done, the compiler needs a little help assembling a correct `KeyPath` for `\EnvironmentValues.theme`. A hint that it should be a `WritableKeyPath` is enough to get it on track.
cweider
commented
Feb 12, 2025
| @@ -1,4 +1,4 @@ | |||
| // swift-tools-version:5.6 | |||
| // swift-tools-version:5.10 | |||
There was a problem hiding this comment.
It could be argued that this should influence swift-markdown-ui’s versioning. It’s a judgement call that could be an argument for deferral and bundling it with StrictConcurrency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A massive number of concurrency warnings concern
KeyPathand issues with its sendability. Rather than chase these down, make use of SE-0418, "Inferring Sendable for Methods and KeyPath Literals".swift-tools-versionis updated to 5.10, making the upcoming feature,InferSendableFromCapturesavailable. Once done, the compiler needs a little help assembling a correctKeyPathfor\EnvironmentValues.theme. A hint that it should be aWritableKeyPathis enough to get it on track.