Skip to content

refactor: move color extension to MD structure #406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zkhCreator
Copy link

when my project with base framework with Color.init(light: lightColor, dark: darkColor), it shows conflict when I compile the project.

Move the functions into the struct to make the overall structure clearer and avoid potential conflicts

Copy link

@cweider cweider left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is removal of public from the extensions a sufficient fix for your purposes? I’m fairly certain the answer is yes and, if so, it’s probable that #386 will merge alone. If not, this would be good to know – you’ll have uncovered another issue that needs addressing in addition to the public extension.

@@ -16,10 +16,10 @@ extension Theme {
/// Table | ![](DocCTable)
public static let docC = Theme()
.text {
ForegroundColor(.text)
ForegroundColor(.MD.DocCTheme.text)
Copy link

@cweider cweider May 3, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I’m noticing pervasive change of indentation from 2 to 4 spaces. For consistency (and in the interest of minimizing the change's size) the 2 space indent should be used.

Note: I’d not worry about rushing out a revision. If done, do it at your leisure. It may be some time before maintainers come through to give their review of the patch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants