Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: save ad-hoc migrated attribute filters via Save as dashboard #6009

Merged
merged 1 commit into from
Mar 5, 2025

Conversation

xMort
Copy link
Contributor

@xMort xMort commented Mar 5, 2025

Ad-hoc updated attribute filters were saved only when dashboard changes were saved from edit mode. When dashboard copy was created via Save as function, the changes to filter context were lost. Attribute filter configs were kept. The fix allows the migrated filters to be saved even from view mode.

JIRA: LX-845
risk: low


Important

Please, don't forget to run rush change for the commits that introduce new features or significant changes 🙏 This information is used to generate the change log.


Run extended test by pull request comment

Commands can be triggered by posting a comment with specific text on the pull request. It is possible to trigger multiple commands simultaneously.

extended-test --backstop | --integrated | --isolated | --record [--filter <file1>,<file2>,...,<fileN>]

Explanation

  • --backstop The command to run screen tests.
  • --integrated The command to run integrated tests against the live backend.
  • --isolated The command to run isolated tests against recordings.
  • --record The command to create new recordings for isolated tests.
  • --filter (Optional) A comma-separated list of test files to run. This parameter is valid only for the --integrated, --isolated, and --record commands.

Examples

extended-test --backstop
extended-test --integrated
extended-test --integrated --filter test1.spec.ts,test2.spec.ts
extended-test --isolated
extended-test --isolated --filter test1.spec.ts,test2.spec.ts
extended-test --record
extended-test --record --filter test1.spec.ts,test2.spec.ts

Ad-hoc updated attribute filters were saved only when dashboard
changes were saved from edit mode. When dashboard copy was created via
Save as function, the changes to filter context were lost. Attribute
filter configs were kept. The fix allows the migrated filters to be
saved even from view mode.

JIRA: LX-845
risk: low
@xMort xMort requested a review from kandl as a code owner March 5, 2025 09:20
@@ -0,0 +1,55 @@
// (C) 2025 GoodData Corporation
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The file contains already merged functions that were extracted from two other files. I can reuse them in save as dashboard handler now which is the core of the fix.

@xMort xMort enabled auto-merge March 5, 2025 09:32
@xMort xMort merged commit f851d08 into master Mar 5, 2025
18 checks passed
@xMort xMort deleted the pdo-lx-824-migrate-attr-filter-label branch March 5, 2025 09:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants