Refactor BandMFExecutionPlanConfig: separate calibration from config.#245
Open
copybara-service[bot] wants to merge 1 commit into
Open
Refactor BandMFExecutionPlanConfig: separate calibration from config.#245copybara-service[bot] wants to merge 1 commit into
copybara-service[bot] wants to merge 1 commit into
Conversation
copybara-service
Bot
force-pushed
the
test_926393400
branch
3 times, most recently
from
af68377 to
7ce2938
Compare
copybara-service
Bot
changed the title
The main reasoning for this change was to make it easier to calibrate a mechanism to things other than epsilon/delta. From speaking with folks at TPDP, we probably want to support calibrating to GDP or TPR/FPR as well in the future. This change will make that feel less clunky. An additional benefit of this change is that the dataclass becomes significantly simpler, with epsilon/delta being removed, accountant being removed, and things like partition type and neighboring relation being automatically inferred based on the other inputs. This should reduce cognitive load for the different classes/functions and make it easier to understand and configure a BandMF mechanism. PiperOrigin-RevId: 926393400
copybara-service
Bot
force-pushed
the
test_926393400
branch
from
7ce2938 to
ef8ab2c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor BandMFExecutionPlanConfig: separate calibration from config.
The main reasoning for this change was to make it easier to calibrate a mechanism to things other than epsilon/delta. From speaking with folks at TPDP, we probably want to support calibrating to GDP or TPR/FPR as well in the future. This change will make that feel less clunky.
An additional benefit of this change is that the dataclass becomes significantly simpler, with epsilon/delta being removed, accountant being removed, and things like partition type and neighboring relation being automatically inferred based on the other inputs. This should reduce cognitive load for the different classes/functions and make it easier to understand and configure a BandMF mechanism.