[Unity-plugin] Context menu for creating Unity terrain components #1504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erez-tom
reviewed
Mar 14, 2024
| @@ -75,17 +80,17 @@ public class MjHeightFieldShape : IMjShape { | |||
| var assetName = scene.GenerationContext.AddHeightFieldAsset(this); | |||
|
|
|||
| if (Application.isPlaying) { | |||
| scene.postInitEvent += (unused_first, unused_second) => | |||
There was a problem hiding this comment.
I had to add these names for our internal tools, please leave them as is.
There was a problem hiding this comment.
Ah, I thought it was my editor applying style, I'll swap it back.
erez-tom
approved these changes
Mar 26, 2024
erez-tom
approved these changes
Apr 1, 2024
…le from Unity terrain.
…int-H/mujoco into feature/unity-hfield-context Merge in changes from remote
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A QoL addition to create and align Unity terrain with hfield geoms. Also includes tweaks to the way the MJCF is constructed (previously the local Y position of the terrain was used as the basehieght, now it can be separately defined in the HField property of the geom).