This repository was archived by the owner on Jun 18, 2024. It is now read-only.
ensure str for the case of bytes type.#223
Open
jnory wants to merge 1 commit intogoogle-research:masterfrom
Open
ensure str for the case of bytes type.#223jnory wants to merge 1 commit intogoogle-research:masterfrom
jnory wants to merge 1 commit intogoogle-research:masterfrom
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
Author
|
@googlebot I signed it! |
|
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I noticed that
create_pretraining_data.pyaborts by the error:The reason why the error occurs is that the variable
piecemay be abytestype in Python 3.I'm using sentencepiece tokenizer, and, the minimal case of the input text is following (the text comes from wikipedia):
This small PR fixes the problem by ensuring
strtype for thepiece.Please let me know if you notice anything.
Sincerely,