Fix prediction output readability and simplify inference installation#18
Open
khazic wants to merge 13 commits intogoogle-research:mainfrom
Open
Fix prediction output readability and simplify inference installation#18khazic wants to merge 13 commits intogoogle-research:mainfrom
khazic wants to merge 13 commits intogoogle-research:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
f311c93 to
48914c2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR fixes a few practical issues around inference and installation:
Why
Directly installing requirements.txt currently pulls in a VCS dependency that is only needed for meta-evaluation, which makes inference setup more fragile than necessary.
Also, both predict scripts currently write JSON using the default ensure_ascii=True, so multilingual content is emitted as Unicode escape sequences. In practice this makes output files harder to inspect.
Finally, metricx23.predict was missing a padding collator, which can break batched inference on variable-length inputs, and its per-device batch size could become zero when the global batch size is smaller than the GPU count.
Validation