Skip to content

Conversation

wenhaozhao
Copy link

Add mcp-tools-java.md to Introduce How to Configure MCP-Tools in ADK-Java

Copy link
Member

@vorburger vorburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we can just merge this as-is ... because this appears to just copy/paste a fair bit of content from https://github.com/wenhaozhao/adk-docs/blob/f2e9128c7c7fd2287c007c7a0fb598dc7c7ef0ca/docs/tools/mcp-tools.md (which is https://google.github.io/adk-docs/tools/mcp-tools/), without even adding it to the navigation. My understanding of how adk-docs are managed is that we use the same MD for Python & Java, and then have language specific sections with those tabs on them? @wenhaozhao would you be willing to update this accordingly?

@vorburger
Copy link
Member

@wenhaozhao I just noticed that (meanwhile) on https://google.github.io/adk-docs/tools/mcp-tools/ there actually is a "For Java, refer to the following sample to define an agent that initializes the MCPToolset" would you perhaps like to simply enhance that and add how to configure timeouts for MCP server, introduced in google/adk-java#272?

@wenhaozhao
Copy link
Author

ok, i'll update this later

@wenhaozhao wenhaozhao force-pushed the feat-mcp_tools_java branch from f2e9128 to 15e0757 Compare August 22, 2025 01:51
Copy link
Member

@vorburger vorburger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. PS: @wenhaozhao you could [separately, also] contribute this to our (brand new) https://github.com/google/adk-java/tree/main/tutorials BTW, if you like ... just a thought.

@wenhaozhao
Copy link
Author

LGTM. PS: @wenhaozhao you could [separately, also] contribute this to our (brand new) https://github.com/google/adk-java/tree/main/tutorials BTW, if you like ... just a thought.

cool!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants