-
Notifications
You must be signed in to change notification settings - Fork 108
test: Introduce AdkWebServerTest #342
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new set of integration tests for the ADK Dev Web API. The primary purpose is to ensure the core API endpoints function correctly by simulating HTTP requests and validating their responses. These tests specifically target the API functionality and do not cover the HTML UI, laying a foundation for robust API behavior.
Highlights
- New Test File: A new test file
AdkWebServerTest.java
has been added to the project's test suite. - API Endpoint Testing: This PR introduces integration tests for various ADK Dev Web API endpoints, including
/list-apps
,/apps/{appName}/users/{userId}/sessions
, and specific session operations (create, get, delete, list). - Technology Used: The tests leverage Spring Boot's
@SpringBootTest
andMockMvc
to simulate HTTP requests and verify API responses, ensuring the web layer behaves as expected.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces integration tests for the AdkWebServer
using MockMvc
. The tests cover basic CRUD operations for sessions. My main feedback is regarding test isolation. Several tests create resources without cleaning them up, which can lead to flaky and unreliable tests. I've provided specific suggestions to fix these issues by ensuring each test cleans up after itself. This will make the test suite more robust.
9853520
to
c4b6b7c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding this! Less likely we'll have silent web server breakages now. Super valuable since we can't automatically test this internally
@Poggecci how about this?
This does NOT (yet) cover the #302 problem (if that even is a real problem; TBC) but just tests the ADK Dev Web API - which seems useful in its own right.
I may follow-up on this by adding test coverage for the actual HTML UI, but let's first review this, and I'll do that (or not) in a future separate PR.