Skip to content

Conversation

vorburger
Copy link
Member

I was confused what was "schema" related... but then figured out that this is literally just the (Maven) version of the https://github.com/modelcontextprotocol/java-sdk, so how about dropping the -schema to make this a bit more clear?

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on improving the clarity of a Maven property name within the core/pom.xml file. The change renames a version property to be more descriptive, ensuring that its purpose is immediately clear to anyone inspecting the project's build configuration. This refactoring enhances maintainability and reduces potential misunderstandings about the property's role.

Highlights

  • Maven Property Renaming: The Maven property mcp-schema.version in core/pom.xml has been renamed to mcp.version. This change aims to clarify that the property refers to the version of the modelcontextprotocol/java-sdk and not a schema, addressing potential confusion.
  • Property Usage Update: All instances where the mcp-schema.version property was used within core/pom.xml, specifically for the io.modelcontextprotocol.sdk:mcp dependency, have been updated to correctly reference the new mcp.version property.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to improve clarity by renaming the mcp-schema.version property to mcp.version in core/pom.xml. This is a positive change. However, the refactoring is incomplete as the old property name is still used in contrib/langchain4j/pom.xml. To maintain consistency and fully realize the benefit of this change, the property should be updated in all relevant modules. I've left a specific comment highlighting this.

Copy link
Collaborator

@Poggecci Poggecci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agree with the clearer naming

@copybara-service copybara-service bot merged commit 72e219c into google:main Aug 22, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants