-
Notifications
You must be signed in to change notification settings - Fork 131
chore: Rename mcp-schema.version property in POM to mcp.version #363
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request focuses on improving the clarity of a Maven property name within the core/pom.xml
file. The change renames a version property to be more descriptive, ensuring that its purpose is immediately clear to anyone inspecting the project's build configuration. This refactoring enhances maintainability and reduces potential misunderstandings about the property's role.
Highlights
- Maven Property Renaming: The Maven property
mcp-schema.version
incore/pom.xml
has been renamed tomcp.version
. This change aims to clarify that the property refers to the version of themodelcontextprotocol/java-sdk
and not a schema, addressing potential confusion. - Property Usage Update: All instances where the
mcp-schema.version
property was used withincore/pom.xml
, specifically for theio.modelcontextprotocol.sdk:mcp
dependency, have been updated to correctly reference the newmcp.version
property.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request aims to improve clarity by renaming the mcp-schema.version
property to mcp.version
in core/pom.xml
. This is a positive change. However, the refactoring is incomplete as the old property name is still used in contrib/langchain4j/pom.xml
. To maintain consistency and fully realize the benefit of this change, the property should be updated in all relevant modules. I've left a specific comment highlighting this.
8296ab7
to
2755b57
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
agree with the clearer naming
2755b57
to
91bef92
Compare
d5ec497
to
b811b6c
Compare
I was confused what was "schema" related... but then figured out that this is literally just the (Maven) version of the https://github.com/modelcontextprotocol/java-sdk, so how about dropping the
-schema
to make this a bit more clear?