Skip to content

Conversation

vorburger
Copy link
Member

No description provided.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @vorburger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a new tutorial module, city-time-weather, demonstrating the creation of an AI agent capable of providing current time and weather information for specified cities. It showcases the use of LlmAgent with custom FunctionTool integrations for real-world data retrieval.

Highlights

  • New Tutorial Module: A new Maven module tutorials/city-time-weather has been added to the project.
  • AI Agent Implementation: Implements a CityTimeWeather class that defines an LlmAgent to answer questions about city time and weather.
  • Function Tool Integration: The agent leverages FunctionTool to expose getCurrentTime and getWeather methods, allowing the LLM to call these functions based on user queries.
  • Dependency Management Update: The dev/pom.xml was updated to use the project's parent version for the google-adk dependency, ensuring consistent versioning.
  • Maven Module Inclusion: The main pom.xml was updated to include the newly added tutorials/city-time-weather module.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new 'city-time-weather' tutorial, demonstrating an agent with multiple tools. The changes are well-contained and include adding the new Maven module, its source code, and updating project configurations. The implementation is a good starting point for a tutorial. I've added a few suggestions in CityTimeWeather.java to enhance code quality by removing an unused variable, making a constant final, and using a more efficient method for string comparison.

@vorburger vorburger force-pushed the tutorials-city-time-weather branch from 561233f to 1a777ba Compare August 18, 2025 19:34
@vorburger
Copy link
Member Author

/gemini review

@vorburger vorburger force-pushed the tutorials-city-time-weather branch from 1a777ba to ad1d275 Compare August 18, 2025 19:36
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new tutorial 'city-time-weather', which demonstrates how to create an agent with tools to get the time and weather for a city. The changes include adding the new Maven module, a README with instructions, and the Java implementation for the agent and its tools.

My review focuses on the new Java code. I've found a critical issue with an invalid regular expression that would cause a runtime exception. I've also included suggestions to improve code quality and performance by following standard Java practices for utility classes and reusing thread-safe objects. The rest of the changes, including Maven configuration, look good.

Copy link
Collaborator

@Poggecci Poggecci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love tutorials!

@vorburger vorburger force-pushed the tutorials-city-time-weather branch from 1cfe876 to 6ce41ef Compare August 23, 2025 10:36
@copybara-service copybara-service bot merged commit 40ec7bc into google:main Aug 24, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants