-
Notifications
You must be signed in to change notification settings - Fork 210
feat(langchain4j): add UsageMetadata extraction from TokenCountEstimator or TokenUsage #623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
Summary of ChangesHello @rhuan080, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request introduces a significant enhancement to the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for extracting token usage metadata, prioritizing a provided TokenCountEstimator and falling back to LangChain4j's built-in TokenUsage. The implementation is logical and is accompanied by a good set of unit tests covering the new functionality.
My review includes two main points for improvement:
- Refactoring Constructors: The number of constructors has doubled, leading to boilerplate. I've suggested considering a builder pattern for better maintainability.
- Exception Handling: There's a
try-catchblock that silently swallows exceptions during token estimation. I've recommended adding logging to aid in debugging potential issues.
Overall, this is a valuable feature addition. Addressing the feedback will improve the robustness and maintainability of the code.
contrib/langchain4j/src/main/java/com/google/adk/models/langchain4j/LangChain4j.java
Show resolved
Hide resolved
contrib/langchain4j/src/main/java/com/google/adk/models/langchain4j/LangChain4j.java
Show resolved
Hide resolved
09f0683 to
34056fc
Compare
…tor or TokenUsage Signed-off-by: Rhuan Rocha <[email protected]> feat(langchain4j): fixing exception treatment Signed-off-by: Rhuan Rocha <[email protected]> feat(langchain4j): fixing exception treatment Signed-off-by: Rhuan Rocha <[email protected]> feat(langchain4j): refactoring constructor Signed-off-by: Rhuan Rocha <[email protected]>
34056fc to
c780e7c
Compare
In this commit, I added support for LlmResponse.usageMetadata to retrieve token usage either from a provided TokenCountEstimator or from LangChain4j’s built-in tokenUsage.
This enables usage like:
If no TokenCountEstimator is provided, chatResponse.tokenUsage() becomes the fallback source for usage metadata.