Skip to content

fix: dev ui url works in sub-apps #2568

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

racinmat
Copy link

Fixes #2072.
Blocked by #2556, it depends on it because of the base_url.
Supersedes #2254 because that did not get requested for review and adk-bot was not triggered there for some reason.
I didn't figure out any better way to do this. Basically we need to have a way how to provide a custom URL to the assets/config/runtime-config.json. I have tested with my project that it works well.

testing plan

I have added test that demonstrates the functionality in a sub-app.

I ran the relevant tests to my code and here are the results, everything passes.

 pytest ./tests/unittests/cli/test_fast_api.py   
======================================================================================================================= test session starts =======================================================================================================================
platform win32 -- Python 3.12.8, pytest-8.4.1, pluggy-1.6.0
rootdir: C:\Projects\others\adk-python
configfile: pyproject.toml
plugins: anyio-4.9.0, langsmith-0.3.45, asyncio-1.1.0, mock-3.14.1, xdist-3.8.0
asyncio: mode=Mode.AUTO, asyncio_default_fixture_loop_scope=function, asyncio_default_test_loop_scope=function
collected 36 items                                                                                                                                                                                                                                                 

tests\unittests\cli\test_fast_api.py ....................................                                                                                                                                                                                    [100%]

@adk-bot adk-bot added bot triaged [Bot] This issue is triaged by ADK bot web [Component] This issue will be transferred to adk-web labels Aug 15, 2025
@adk-bot adk-bot requested a review from wyf7107 August 15, 2025 21:49
@racinmat
Copy link
Author

racinmat commented Aug 15, 2025

@wyf7107 see how this PR is fixing the issues in the code, #2072 (comment)
and here the tests pass, you can verify it by running such test without the fix from my PR. It will fail.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bot triaged [Bot] This issue is triaged by ADK bot web [Component] This issue will be transferred to adk-web
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Javascript is broken with FastAPI sub-application.
2 participants