fix indentation for generation_params assignment

[Sabreclaw]

Fixes #2763
generation_params is giving NoneType exception for this error

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Summary of Changes

Hello @Sabreclaw, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a "NoneType" exception related to the "generation_params" variable by correcting an indentation error within the "_get_completion_inputs" function. The change ensures that the check for an empty "generation_params" dictionary is performed at the correct scope, preventing the variable from being incorrectly set to "None" prematurely and thus resolving the reported exception.

Highlights

• Indentation Fix: Corrected the indentation of the "if not generation_params:" block within the "_get_completion_inputs" function in "src/google/adk/models/lite_llm.py". This change moves the conditional check outside of the loop where "generation_params" is populated, ensuring it's evaluated at the correct scope.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[adk-bot]

Response from ADK Triaging Agent

Hello @Sabreclaw, thank you for creating this PR!

Before we can merge your contribution, we need to ask you to complete a few items based on our contribution guidelines:

• Sign our Contributor License Agreement (CLA): It looks like the CLA check has failed. Please visit https://cla.developers.google.com/ to sign the agreement.
• Associate an Issue: For bug fixes, we require an associated GitHub issue. Could you please create one that describes the bug and link it in the PR description?
• Provide a Testing Plan: Please add a Testing Plan section to your PR description, explaining how you verified the fix. Including logs or a screenshot that shows the NoneType exception is resolved would be very helpful for the reviewers.

You can find more details in our contribution guidelines. Thank you!

[gemini-code-assist]

Code Review

This pull request correctly fixes a NoneType exception by adjusting the indentation of the logic that handles generation_params. The change ensures that generation_params is checked for emptiness only after the loop that populates it has completed. I've also added a suggestion to refactor the parameter extraction logic to be more concise and Pythonic, which could further improve code clarity and maintainability.

[ankursharmas]

Can you please add a unit test case to cover this case.

https://github.com/google/adk-python/blob/main/tests/unittests/models/test_litellm.py