Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reenable workflow test #2638

Open
jingtang10 opened this issue Jul 25, 2024 · 1 comment
Open

Reenable workflow test #2638

jingtang10 opened this issue Jul 25, 2024 · 1 comment
Assignees
Labels
P1 High priority issue type:code health

Comments

@jingtang10
Copy link
Collaborator

jingtang10 commented Jul 25, 2024

Describe the bug
A number of workflow library tests have been disabled in #2637 as a result of the upgrade the clinical reasoning dependencies from 3.0 prerelease to 3.8.

Some are results of our test code no longer doing the right thing (for example mixing urls with verions), but we also need to rethink how deep we want to test the clinical reasoning module -- we want to make sure it works on android, but i'm not sure we need to check that every single code path is executed and tested. It's not realistic, and not necessary. We need to make sure our test cases are typical, cover the "happy paths" and are easy to maintain.

Additionally, some of these tests probably should be moved to clinical reasoning codebase.

So we probably want to fix some of these tests, but also retire some of these tests that we no longer think are useful.

Component
Workflow lib

To Reproduce
Run the tests

Expected behavior

Screenshots
If applicable, add screenshots to help explain your problem.

Smartphone (please complete the following information):
NA

Additional context
Add any other context about the problem here.

Would you like to work on the issue?
Please state if this issue should be assigned to you or who you think could help to solve this issue.

@jingtang10
Copy link
Collaborator Author

@santosh-pingle santosh-pingle added ux testing type:code health P2 Medium priority issue P1 High priority issue and removed ux testing P2 Medium priority issue labels Jul 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
P1 High priority issue type:code health
Projects
Status: New
Development

No branches or pull requests

3 participants