Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update clinical reasoning dependencies #2637

Merged
merged 14 commits into from
Jul 26, 2024

Conversation

jingtang10
Copy link
Collaborator

@jingtang10 jingtang10 commented Jul 24, 2024

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Description
Update clinical reasoning dependencies to 3.8.0

Include logback-android dependency and exclude logback-classic for build to work on Android.

Ignore tests that are currently failing. Follow up in #2638

Alternative(s) considered
NA

Type
Builds

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

Copy link
Collaborator

@aditya-07 aditya-07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Two major apis that have been affected with this change are FhirOperator.generateCarePlan and FhirOperator.evaluateMeasure.
Even though generateCarePlan tests seem to be working fine, but all of evaluateMeasure tests kept failing and had to be ignored. In the follow up #2638, we should ensure that we have tighter tests for all the affected functionality.

@jingtang10 jingtang10 merged commit 9bd76c8 into google:master Jul 26, 2024
8 checks passed
@jingtang10 jingtang10 deleted the clinical-reasoning-deps branch August 5, 2024 10:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Complete
Development

Successfully merging this pull request may close these issues.

3 participants