-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update clinical reasoning dependencies #2637
Update clinical reasoning dependencies #2637
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
Two major apis that have been affected with this change are FhirOperator.generateCarePlan
and FhirOperator.evaluateMeasure
.
Even though generateCarePlan
tests seem to be working fine, but all of evaluateMeasure
tests kept failing and had to be ignored. In the follow up #2638, we should ensure that we have tighter tests for all the affected functionality.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Description
Update clinical reasoning dependencies to
3.8.0
Include
logback-android
dependency and excludelogback-classic
for build to work on Android.Ignore tests that are currently failing. Follow up in #2638
Alternative(s) considered
NA
Type
Builds
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.