-
Notifications
You must be signed in to change notification settings - Fork 294
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump CQL Translator/Evaluator to 2.4 #1771
Conversation
:( We are going to need HAPI 6.3 to push this forward (We need that caffeine/guava modules shipped to Maven central) |
This is now ready to be reviewed. @jingtang10 @omarismail94 @ktarasenko @pld We need this for a more stable plan definition release. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@vitorpamplona thanks for working this out this is great. why do we need hapi 6.3?
fyi @brynrhodes
Codecov Report
@@ Coverage Diff @@
## master #1771 +/- ##
=============================================
+ Coverage 0 41.82% +41.82%
- Complexity 0 383 +383
=============================================
Files 0 153 +153
Lines 0 5513 +5513
Branches 0 991 +991
=============================================
+ Hits 0 2306 +2306
- Misses 0 2838 +2838
- Partials 0 369 +369
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Hey @jingtang10 take a look on this one again.
Hapi 6.3 is when Smile ships the service loaders to get rid of Caffeine. It should come out soon. |
Description
antlr
fix due to the fix being applied in this version of the Translator.generateCarePlan
to return IBaseResource to prepare for R5.Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: Code health
Screenshots (if applicable)
Checklist
./gradlew spotlessApply
and./gradlew spotlessCheck
to check my code follows the style guide of this project../gradlew check
and./gradlew connectedCheck
to test my changes locally.