Add Launch and Submission Timestamps to QR #2672
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
7 tasks
jingtang10
reviewed
Sep 17, 2024
| @@ -154,3 +159,21 @@ private fun unpackRepeatedGroups( | |||
| listOf(questionnaireResponseItem) | |||
| } | |||
| } | |||
|
|
|||
| /** Adds a launch timestamp as an extension to the Questionnaire Response */ | |||
There was a problem hiding this comment.
can you clarify in the doc that we only add the launch timestamp if there isn't one at the moment?
There was a problem hiding this comment.
or should we make this extension repeated so that each time you edit the questionnaire response it is recorded.
useful for audit purposes?
There was a problem hiding this comment.
OR if we really want to only keep one (to be a bit more consistent with the authored fied) we can rename this extension to lastLaunched?
jingtang10
reviewed
Sep 17, 2024
Comment on lines
+706
to
+708
| val launchTimestamp = questionnaireResponse.launchTimestamp | ||
| assertThat(launchTimestamp).isNotNull() | ||
| assertThat(dateTimeType).isEqualTo(launchTimestamp) |
There was a problem hiding this comment.
these 3 lines can be collapsed into 1. no need to check if it's not null if you're going to compare it anyway
jingtang10
reviewed
Sep 17, 2024
Comment on lines
+715
to
+716
| val launchTimestamp = questionnaireResponse.launchTimestamp | ||
| assertThat(launchTimestamp).isNull() |
jingtang10
reviewed
Sep 17, 2024
Comment on lines
+727
to
+729
| val launchTimestamp = questionnaireResponse.launchTimestamp | ||
| assertThat(launchTimestamp).isNotNull() | ||
| assertThat(oldDateTimeType).isEqualTo(launchTimestamp) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2372
Description
Clear and concise code change description.
Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?
Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.