Skip to content

Conversation

LZRS
Copy link
Collaborator

@LZRS LZRS commented Aug 26, 2025

IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).

Fixes #2855

Description
This PR tries to move the functionality in EditTextViewHolderFactory.kt to use JetPack Compose.
Consequently

  • EditTextDecimalViewHolderFactory
  • EditTextIntegerViewHolderFactory
  • EditTextMultiLineViewHolderFactory
  • EditTextSingleLineViewHolderFactory
  • PhoneNumberViewHolderFactory
  • EditTextStringViewHolderDelegate

that had inherited EditTextViewHolderFactory now inherit QuestionnaireItemComposeViewHolderFactory, and are also moved to Compose

Alternative(s) considered
Have you considered any alternatives? And if so, why have you chosen the approach in this PR?

Type
Choose one: (Bug fix | Feature | Documentation | Testing | Code health | Builds | Releases | Other)

Screenshots (if applicable)

Checklist

  • I have read and acknowledged the Code of conduct.
  • I have read the Contributing page.
  • I have signed the Google Individual CLA, or I am covered by my company's Corporate CLA.
  • I have discussed my proposed solution with code owners in the linked issue(s) and we have agreed upon the general approach.
  • I have run ./gradlew spotlessApply and ./gradlew spotlessCheck to check my code follows the style guide of this project.
  • I have run ./gradlew check and ./gradlew connectedCheck to test my changes locally.
  • I have built and run the demo app(s) to verify my change fixes the issue and/or does not break the demo app(s).

Affecting questionnaire item of types string, integer, text, decimal, phone
@LZRS LZRS force-pushed the edit-text-compose-view-holder-factory branch from a4f2e1c to becfe14 Compare September 10, 2025 13:59
@LZRS LZRS marked this pull request as ready for review October 1, 2025 12:46
@LZRS LZRS requested a review from a team as a code owner October 1, 2025 12:46
@LZRS LZRS requested a review from ktarasenko October 1, 2025 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: New
Development

Successfully merging this pull request may close these issues.

Migrate EditTextViewHolderFactory to compose
1 participant