Fix answer option match for coding initial expression #2887
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jingtang10
approved these changes
Oct 1, 2025
Comment on lines
+3184
to
+3185
| assertThat(selectedOption.initialSelected).isTrue() | ||
| assertThat(question.answerOption.count { it.initialSelected }).isEqualTo(1) |
There was a problem hiding this comment.
this is just testing the createObservationChoiceQuestionnaire function no? i don't think this is necessary.
the important thing in the test case is below: the generated questionnaire response from the population process includes selected answers.
=====
actually, this reveals a problem in the populate function (thanks laz for pointing out) i dont' think it should change the questionnaire... can you fix that?
| ) | ||
|
|
||
| val question = questionnaire.item.single() | ||
| assertThat(question.answerOption.none { it.initialSelected }).isTrue() |
github-project-automation
bot
moved this from New
to PR under Review
in Android FHIR SDK
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMPORTANT: All PRs must be linked to an issue (except for extremely trivial and straightforward changes).
Fixes #2880
Description
Replaced deep equal check for answerOption in populateInitialValues to a more custom logic for Coding Type & keeping the behavior same for other types.
Alternative(s) considered
None | Looking forward to feedback
Type
Bug fix
Screenshots (if applicable)
Checklist
./gradlew spotlessApplyand./gradlew spotlessCheckto check my code follows the style guide of this project../gradlew checkand./gradlew connectedCheckto test my changes locally.